fix(crawlers): Keep the crawler usable after a failed run - #2255
Merged
Merged
Conversation
vdusek
added
t-tooling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2255 +/- ##
==========================================
- Coverage 93.74% 93.73% -0.01%
==========================================
Files 181 181
Lines 12884 12890 +6
==========================================
+ Hits 12078 12083 +5
- Misses 806 807 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
changed the title
vdusek
changed the title
vdusek
marked this pull request as ready for review
September 24, 2026 13:06
apify-service-account
added
the
tested
Pijukatel
approved these changes
Sep 29, 2026
vdusek
added a commit
that referenced
this pull request
Sep 29, 2026
…eases its files (#2239) `PlaywrightPersistentBrowser.close()` removed the temp profile directory with one `shutil.rmtree(ignore_errors=True)` call. On Windows the browser can still hold files there, so the directory leaked silently. The removal now retries (50 × 100 ms) and logs a warning if it never succeeds. `close()` and the context's `close` listener both trigger it; a lock makes it run once, and `close()` waits until it finishes. Fixes the flaky `test_delete_temp_folder_with_close_browser` on `windows-latest` ([run 35085779018](https://github.com/apify/crawlee-python/actions/runs/35085779018), [run 35991074349](https://github.com/apify/crawlee-python/actions/runs/35991074349/job/107605022234)). The crawler state fixes moved to #2255. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2229, split out of #2239.
Crawler state after a failed run
add_requests) left_runningset, so every laterrun()raisedRuntimeError. The whole run body is now inside thetry/finally._last_run_failedflag now skips that purge, even withpurge_request_queue=True. A failure in the post-crawl steps (statistics,_save_crawler_state()) counts as a failed run.AutoscaledPool
run.result.exception()is guarded against a cancelled future. On SIGINT it raisedCancelledErrorin the orchestrator'sfinally, and the error log was lost.Unpropagated exception in worker task orchestrator, so it can be told apart from the same message inrun().✍️ Drafted by Claude Code